Hide topic bugs

18.08.2009 22:41:34
Peter
 I recently stumbled upon this forum, and I have to say I love it. It's really lightweight and easily customizable, which is exactly what I need for various projects. The template system really could be improved, but hey :)

I found two bugs with hiding messages.
Seems you have a typo in /inc/publish.php on line 46:
print($theThread ? ("?exp=" . $theThread->getId()) : "")); should be print($theThread ? ("?exp=" . $theThread->getId()) : "");
Else you'll recieve an error when hiding a message.

Second one happens when there's a hidden topic and you're not logged in as administrator.
Fatal error: Cannot break/continue 1 level in //inc/functions.php on line 198
Don't think you can use a continue in a function, even if that function is in a whileloop. Or maybe it's just my server.
I didn't found a decent solution for it yet, will let you know if I do.

Keep up the good work!
19.08.2009 08:54:22

Nikke
Quote from Peter on 18.08.2009 22:41:34
I recently stumbled upon this forum, and I have to say I love it. It's really lightweight and easily customizable, which is exactly what I need for various projects. The template system really could be improved, but hey :)


Thank you, I'm glad you've found Elf useful to you. The template system could and should indeed be improved, and eventually it probably will be, too, since it isn't very friendly to non-programmers as it is. The current version is a first draft of the new system, which is (believe it or not) still a huge improvement from what it used to be. There are plans regarding this, but it's not a high priority.

Quote from Peter on 18.08.2009 22:41:34
I found two bugs with hiding messages.
Seems you have a typo in /inc/publish.php on line 46:
print($theThread ? ("?exp=" . $theThread->getId()) : "")); should be print($theThread ? ("?exp=" . $theThread->getId()) : "");
Else you'll recieve an error when hiding a message.

Second one happens when there's a hidden topic and you're not logged in as administrator.
Fatal error: Cannot break/continue 1 level in //inc/functions.php on line 198
Don't think you can use a continue in a function, even if that function is in a whileloop. Or maybe it's just my server.
I didn't found a decent solution for it yet, will let you know if I do.


Thanks for the bug report, I'll look into these right away. These are really due to lack of testing, but I myself don't have enough time to do proper testing, so sadly it's been left to you end users. (But to my defense, the versions are marked as unstable ;-)

I'll try to get up a fixed version asap.
19.08.2009 10:32:44

Nikke
These bugs have now been addressed and a fixed version is available for download.
19.08.2009 13:17:57

Peter
Awesome, works like a charm! Thanks for the fast update :)

There were some other things I ran into. Not important for me, since I adjust most of it, but maybe it would be usefull for you to know.

If you install a language, but don't enter a name, a clickable (working) flag will show up in the language menu, but it won't show as installed in the configuration panel.

The threads per page option doesn't work for me.

When you lock a thread, you get redirected to the main page instead of the message itself (other actions will redirect to the message).


Also, would you be intrested in a dutch translation I made?
21.08.2009 22:31:21

Nikke
Quote from Peter on 19.08.2009 13:17:57
If you install a language, but don't enter a name, a clickable (working) flag will show up in the language menu, but it won't show as installed in the configuration panel.

I think I've actually run into this, but have forgotten about it. Thanks, I'll check it out.

Quote from Peter on 19.08.2009 13:17:57
The threads per page option doesn't work for me.

Yes, the paging feature is disabled at the moment, because it's in the process of being rewritten. There are some unsolved issues still which are holding this back, but it'll be there. Check out the roadmap for what's going on behind the scenes: elfbb.nikc.org/?exp=37

Quote from Peter on 19.08.2009 13:17:57
When you lock a thread, you get redirected to the main page instead of the message itself (other actions will redirect to the message).

Not sure if I'd count this as a bug though, more of a personal preference, but consistency is ofcourse always a good idea. Thanks for pointing this out.

Quote from Peter on 19.08.2009 13:17:57
Also, would you be intrested in a dutch translation I made?

Sure, as long as you're willing to keep it up to date :-)
02.09.2009 17:15:27

Peter
Quote from Nikke on 21.08.2009 22:31:21
Yes, the paging feature is disabled at the moment, because it's in the process of being rewritten. There are some unsolved issues still which are holding this back, but it'll be there. Check out the roadmap for what's going on behind the scenes: elfbb.nikc.org/?exp=37

Sorry, I missed that.

Quote from Nikke on 21.08.2009 22:31:21
Not sure if I'd count this as a bug though, more of a personal preference, but consistency is ofcourse always a good idea. Thanks for pointing this out.

Yeah, it's not a bug at all. But like you said, I think consistency is a good thing. Just wanted to make you aware of it :)

Quote from Nikke on 21.08.2009 22:31:21
Sure, as long as you're willing to keep it up to date :-)

Can do. Is there any way to keep informed about new versions other then visiting this forum?
13.09.2009 09:55:09

Nikke
Quote from Peter on 02.09.2009 17:15:27
Quote from Nikke on 21.08.2009 22:31:21
Sure, as long as you're willing to keep it up to date :-)

Can do. Is there any way to keep informed about new versions other then visiting this forum?


Not at the moment, but I have been planning to either create a mechanism for that, or at the very least, start a mailing list for announcements. Neither will happen before version 2, though.

And further more, I'm not sure how actively I'll be developing Elf further after I've actually reached version 2. It all remains to be seen after that point. But version 2 will be reached, that much I've promised myself.